Skip to content

Add recursive arg to mkdir #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2022
Merged

Add recursive arg to mkdir #53

merged 4 commits into from
Jan 8, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Enables a variant of mkdir that works when multiple directories in the path don't exist.

https://nodejs.org/api/fs.html#fspromisesmkdirpath-options

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez mentioned this pull request Jan 6, 2022
Closed
4 tasks
garyb
garyb reviewed Jan 6, 2022
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir' is exported too, so this is a breaking change in its current form, is that the way we want to go?

@JordanMartinez
Copy link
Contributor Author

I can refactor this to use a different FFI call rather than going through mkdir'. When we do breaking changes in the future, we can merge the two then.

@JordanMartinez JordanMartinez mentioned this pull request Jan 6, 2022
Closed
@JordanMartinez JordanMartinez merged commit 40dda13 into purescript-node:master Jan 8, 2022
@JordanMartinez JordanMartinez deleted the addRecursive branch January 8, 2022 15:51
@JordanMartinez JordanMartinez mentioned this pull request Jan 10, 2022
Merged
4 tasks
@JordanMartinez JordanMartinez mentioned this pull request Mar 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @garyb